Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.0 #116

Merged
merged 9 commits into from
Feb 7, 2017
Merged

1.0 #116

merged 9 commits into from
Feb 7, 2017

Conversation

lgrahl
Copy link
Member

@lgrahl lgrahl commented Feb 6, 2017

@lgrahl lgrahl added this to the Protocol Polishing milestone Feb 6, 2017
@lgrahl lgrahl requested a review from dbrgn February 6, 2017 11:50
In order to establish a signalling channel using SaltyRTC, the following
information has to be available to both peers:

* WebSocket URI scheme (`ws` or `wss`),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we always require wss?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah: Although the SaltyRTC protocol takes many security measures to prevent eavesdropping, it is still highly RECOMMENDED to use WebSocket in its secure mode

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's optional but recommended.

Protocol.md Outdated
```
<scheme>://<server-host>:<server-port>/<signalling-path>
?<server-permanent-public-key>#<authentication-token-hex>
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd format this by indentation, it's easier to read in ASCII form and the result is the same.

Readme.md Outdated
Note that the specifications' versions are independent from each other.
In case a new version of a specification breaks backwards compatibility
to another specification, it will include a section stating how
compatibility is affected.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should also include a CHANGELOG.md file?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest adding a Changelog section into the specification once a specification is being updated. Having one log for several specs seems confusing to me. What do you think?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good.

Release Process
===============

Signing key: https://lgrahl.de/pgp-key.txt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd recommend to include the fingerprint too.

Releasing.md Outdated
export VERSION=protocol|chunking-<version>
# For tasks:
export VERSION=task-<task-name>-<version>
export GPG=0482ABA6
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you specify the full fingerprint? https://evil32.com/

@lgrahl
Copy link
Member Author

lgrahl commented Feb 6, 2017

Ok now?

@lgrahl lgrahl merged commit 36016ef into master Feb 7, 2017
@lgrahl lgrahl deleted the pre-release branch February 7, 2017 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Specify recommended exchange message Pre-Release-List
2 participants